atiaomar1978-hub commented on PR #24844: URL: https://github.com/apache/camel/pull/24844#issuecomment-5226880587
## Bugbot — test coverage review Assessed unit + IT coverage for `camel-apicurio-registry` (~890 LOC tests across 7 classes + test-infra). ### Coverage matrix (producer operations) | Operation | Unit (mock SDK) | IT (Testcontainers) | |-----------|-----------------|---------------------| | `createArtifact` | ✅ | ✅ lifecycle IT | | `updateArtifact` | ✅ | ✅ lifecycle IT | | `deleteArtifact` | ✅ | ✅ lifecycle IT | | `getArtifactContent` | ✅ | ✅ lifecycle IT | | `getArtifactMetadata` | ✅ | ✅ lifecycle IT | | `listVersions` | ✅ | ✅ lifecycle IT | | `createGroup` | ✅ | ✅ lifecycle IT | | `searchArtifacts` | ❌ route only, no test | ✅ dedicated IT | | `testCompatibility` | ❌ | ⚠️ happy path only (`assertNotNull` body) | | `validate` | ❌ | ⚠️ `failOnValidation=false`, header non-null only | ### Consumer coverage | Scenario | Unit | IT | |----------|------|-----| | Poll new versions (mock) | ✅ | — | | Skip already-seen globalId | ✅ | — | | Real registry poll | — | ⚠️ single version, headers only | | `fetchContent=true` | ❌ | ❌ | | Second version after initial poll | ❌ | ❌ | | Missing groupId/artifactId error | ❌ | ❌ | ### Config / auth | Area | Covered? | |------|----------| | URI parsing (group / group+artifact) | ✅ ComponentTest | | `configuration.copy()` | ✅ | | `EndpointServiceLocation` | ✅ | | Basic auth **options binding** | ✅ (no live auth call) | | OIDC auth | ❌ | | `cacheTtl` option | ❌ (also unused in prod code) | ### Verdict **Adequate for Preview merge** — strong lifecycle IT and good mocked coverage for core CRUD. **Not yet comprehensive** for a GA component: three producer ops lack unit tests, validation/compatibility negative paths are thin, consumer watermark/`fetchContent` gaps, and auth is config-only. **Priority additions before promotion:** 1. Unit tests for `searchArtifacts`, `validate`, `testCompatibility` 2. Negative validate/compatibility ITs + `ApicurioRegistryValidationException` when `failOnValidation=true` 3. Consumer IT: second version + optional `fetchContent=true` 4. Consumer unit test for out-of-order `globalId` (guards known watermark risk) _AI-generated Bugbot test-coverage review on behalf of atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
