atiaomar1978-hub commented on PR #25498: URL: https://github.com/apache/camel/pull/25498#issuecomment-5303111226
Addressed davsclaus review feedback in commit `18959c6`. **Changes:** - Removed `@Metadata(required = true)` from SLS `region` — `endpoint` alone is valid per `AlibabaSlsUtils.createClient()` - Delegated OTS credential resolution to shared `OpenApiClientSupport` (removed duplicate methods) - Reworked `AlibabaOtsEndpointTest.initClientReturnsCachedInstance` to use a mock client (no real SDK / network I/O) - Added `STATUS_CODE` to `AlibabaSlsProperties` and referenced it from `AlibabaSlsHeaders` - Fixed alphabetical ordering: `camel-alibaba-ots` before `camel-alibaba-sls` in `coverage/pom.xml` and `nav.adoc` (BOM was already correct) **SLS client shutdown:** Checked `com.aliyun.sls20201230.Client` (extends `com.aliyun.teaopenapi.Client`) — no public `close()` or `shutdown()` method. Alibaba OpenAPI SDK docs state the client is GC-managed. Matches other Tea OpenAPI Alibaba components (EventBridge, KMS, FC, SMS). OTS differs because `SyncClient` exposes `shutdown()`. **Tests:** `./mvnw -pl components/camel-alibaba/camel-alibaba-sls,components/camel-alibaba/camel-alibaba-ots test` — all 20 tests pass. _AI-generated on behalf of atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
