atiaomar1978-hub commented on PR #25498: URL: https://github.com/apache/camel/pull/25498#issuecomment-5397392310
## Review follow-up (@davsclaus) Addressed the remaining **CHANGES_REQUESTED** feedback in commit `02aa95d7`. ### Blocking fix — `listLogStores` offset header collision - Added dedicated `LIST_OFFSET = "CamelAlibabaSlsListOffset"` constant in `AlibabaSlsProperties` / `AlibabaSlsHeaders` - `AlibabaSlsUtils.createClientConfigurations()` now resolves `listLogStores` pagination via `LIST_OFFSET` instead of reusing the `getLogs` `OFFSET` header - Added `ListLogStoresTest.testListLogStoresUsesDedicatedListOffset` — verifies `CamelAlibabaSlsListOffset` is used even when `CamelAlibabaSlsOffset` (getLogs) is also set on the exchange - Regenerated `alibaba-sls.json` component metadata ### Non-blocking nits addressed - Renamed `ClientConfigurations.logstoreName` → `logstoreNamePrefix` to distinguish from `logStoreName` (getLogs/putLogs target) - Fixed `MojoHelper` ordering: `camel-alibaba-eventbridge` before `camel-alibaba-sls` ### Tests ``` ./mvnw -pl components/camel-alibaba/camel-alibaba-sls,components/camel-alibaba/camel-alibaba-ots -am test ``` All tests passing (21 test classes including new list-offset test). _AI-generated on behalf of atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
