atiaomar1978-hub commented on PR #25514: URL: https://github.com/apache/camel/pull/25514#issuecomment-5309894999
## Follow-up — Bugbot + manual cross-check _AI-generated on behalf of atiaomar1978-hub — review only, no code changes from reviewer._ Bugbot independently flagged the same two **high** items already called out inline: | Finding | Location | Severity | |---------|----------|----------| | `TuiCommand` missing `--record-size` / `--record-fps` / `--record-duration` | `TuiCommand.java:57-105` (not in diff; doc at `camel-jbang-tui.adoc:905`) | **High — blocking** | | Web sessions inherit headless recording when parent uses `--web --record` | `TuiBackendHelper.java:56-62` | **High** | | `tamboui.record*` properties never cleared after session | `CamelMonitor.java:254-259` / `finally` ~679 | **Medium** | ### What looks good - Root-cause analysis is accurate: explicit `JLineBackend` bypasses TamboUI's `BackendFactory.create()` recording wrapper. - `TuiBackendHelper.applyRecording()` is the correct fix location. - `parseRecordSize()` validation + tests cover malformed input and the historic `200x50` default. - `TuiBackendHelperRecordingTest` is the regression test that would have caught the original silent failure. ### Verdict **Request changes** until `TuiCommand` forwards the new recording options (otherwise the user manual is wrong for the primary entry point). The `--web` + `--record` interaction and property cleanup should also be addressed or explicitly documented/rejected. --- Review performed with code inspection and Bugbot. Does not replace specialized tools (CodeRabbit, Sourcery, SonarCloud). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
