ammachado commented on PR #25514:
URL: https://github.com/apache/camel/pull/25514#issuecomment-5309972740

   ## Upstream follow-up link (review suggestion #5)
   
   The TamboUI change is now open: 
**https://github.com/tamboui/tamboui/pull/418** ("fix: apply recording to 
explicitly configured backends").
   
   It does what the "Follow-up upstream" section of this PR describes:
   
   - exposes the wrapping as a public `BackendFactory.applyRecording(Backend)` 
and reuses it inside `create()`;
   - makes `TuiRunner.create()` apply it to explicitly configured backends, so 
the bug is fixed at the source for every downstream caller rather than each one 
remembering;
   - keeps `applyRecording` **idempotent**, which is what lets the Camel-side 
wrap in `TuiBackendHelper` and the upstream one coexist safely. Stacking two 
`RecordingBackend`s would otherwise give the outer wrapper its own 
`InteractionPlayer`, consuming the tape while the inner recorder saw no input.
   
   So once the TamboUI version pin moves past that release, 
`TuiBackendHelper.applyRecording()` and its dependency on 
`dev.tamboui.internal.record` can simply be deleted, with no behavior change in 
between.
   
   _Claude Code on behalf of @ammachado_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to