oscerd opened a new pull request, #2974:
URL: https://github.com/apache/camel-kamelets/pull/2974
Fixes #2971
### 1. `dropbox-source` — the delete is now declared and switchable
The Kamelet deleted every file it consumed via an unconditional
`dropbox:del`, with no property controlling it and no mention in the
description ("Consume Files"). An operator reading the schema had no way to
learn the folder gets emptied.
```diff
- - toD:
"dropbox:del?...&remotePath=${exchangeProperty.dropboxFileName}"
+ - choice:
+ when:
+ - simple: '{{deleteAfterRead}}'
+ steps:
+ - toD:
"dropbox:del?...&remotePath=${exchangeProperty.dropboxFileName}"
```
**The default is `true`, not `false`** — deliberately. My first pass at this
issue proposed `false` to match `azure-storage-blob-source`, which was wrong:
`dropbox-source` polls with `timer` + `dropbox:search` and has **no**
idempotent consumer or repository. The delete is what stops the next poll
re-delivering the same files, so defaulting it off would turn every `period`
tick into a re-delivery of the whole folder.
So this is a no-op at runtime. What changes is that the destruction is now
visible in the schema and in tooling, and an operator who has added their own
idempotency can switch it off. Making `false` safe would additionally need an
idempotent consumer — noted in the issue as separate work.
The gate uses `{{deleteAfterRead}}` rather than the
`${properties:deleteAfterRead:true}` form the sibling Kamelets use. That is not
cosmetic: `${properties:...}` does not register as a use, so the validator
rejects the property as declared-but-unused, and the existing Kamelets work
around that by being listed in `verifyUsedParams`'s exclusion list in
`script/validator/validator.go`. Adding `dropbox-source` there would disable
the unused-parameter check for *every* property in the file. Verified both
branches with `camel run`: default → delete runs, `deleteAfterRead=false` →
skipped.
> Side note for a maintainer: that exclusion list is why #2958's dead
`queueURL` went unnoticed — `aws-sqs-source` and `aws-s3-event-based-source`
are both on it. Once #2965 lands, those two may be removable from the list.
### 2. `azure-storage-blob-event-based-source` — exact container match
```diff
- ... && ${exchangeProperty.azure-storage-blob-subject} contains
"{{containerName}}"
+ ... && ${exchangeProperty.azure-storage-blob-subject} startsWith
"/blobServices/default/containers/{{containerName}}/blobs/"
```
The subject comes from the Event Grid event's `$.subject`, shaped
`/blobServices/default/containers/<container>/blobs/<path>`, where `<path>` is
chosen by whoever uploaded the blob. `contains` therefore matched on the blob
path too. The `google-storage-event-based-source` sibling already uses strict
equality.
Verified with `camel run`:
| subject | configured container | result |
|---|---|---|
| `/blobServices/default/containers/mycontainer/blobs/report.csv` |
`mycontainer` | matches |
| `/blobServices/default/containers/other/blobs/mycontainer/evil.csv` |
`mycontainer` | no match |
| `/blobServices/default/containers/mycontainer-staging/blobs/x.csv` |
`mycontainer` | no match |
The last two both matched under `contains`.
### Verification
- `script/validator` reports no errors
- `mvn verify` passes
- Both fixes exercised with `camel run` as described; no live Dropbox or
Azure endpoint involved
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
