mayurbm commented on PR #25554: URL: https://github.com/apache/camel/pull/25554#issuecomment-5402932466
Hi @davsclaus, thank you for the review! Addressed all three comments: **Comment 1 & 2 part 1 — duplicate `extractUsefulMessage` (`InternalRouteStartupManager.java` lines 431/522):** Removed the private `extractUsefulMessage()` method from `InternalRouteStartupManager` and replaced both call sites with `RouteService.extractUsefulMessage(e)` directly. Both classes are in the same package (`org.apache.camel.impl.engine`) so the package-private static method on `RouteService` is accessible without any changes to `RouteService` itself. **Comment 2 part 2 — `"null"` literal edge case:** Acknowledged — the `msg != null && !msg.isBlank()` guard in `RouteService.extractUsefulMessage` would return the literal string `"null"` if an exception was constructed with `String.valueOf(nullRef)`. This is an existing behaviour in `RouteService.extractUsefulMessage` (now shared), not introduced by this PR. Happy to address it as a follow-up if desired. **Comment 3 — `public` on test class and `@Test` methods:** Dropped `public` from the test class `InternalRouteStartupManagerConsumerStartTest` and both `@Test` methods to follow project convention (package-private). The override methods deeper in the file (`configure()`, `createConsumer()`, etc.) keep their `public` visibility as required. Local validation: - `mvn formatter:format impsort:sort` on `core/camel-base-engine` and `core/camel-core` — no changes needed - `InternalRouteStartupManagerConsumerStartTest`: Tests run: 2, Failures: 0 - `MainSupervisingRouteControllerTest`: Tests run: 3, Failures: 0 - `SpringSupervisingRouteControllerTest`: Tests run: 1, Failures: 0 All 3 review threads resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
