mayurbm commented on PR #25554: URL: https://github.com/apache/camel/pull/25554#issuecomment-5413145984
Hi @davsclaus, I hope the reworked fix addresses your concerns. To summarise what was done: - The wrapping is now **narrowly scoped** — only applies when the exception carries a null or blank message (the exact CAMEL-24404 case). Exceptions that already have a message propagate unchanged, so no existing callers are affected. - Removed the duplicate `extractUsefulMessage()` and delegated to `RouteService.extractUsefulMessage(e)` directly. - Only **2 files changed**: `InternalRouteStartupManager.java` and `InternalRouteStartupManagerConsumerStartTest.java`. - All previously broken tests (`DefaultSupervisingRouteControllerTest`, `MainSupervisingRouteControllerTest`, `SpringSupervisingRouteControllerTest`, `NettyHttpTwoRoutesValidateBootstrapConfigurationTest`, `AiToolEndpointLifecycleTest`, `JmsTestConnectionOnStartupTest`) now pass with their original assertions — no test changes were needed. Would you be happy to take another look when you get a chance? And if the fix looks good to you, could you please trigger a CI re-run at your convenience? The last CI failure was caused by pre-existing flaky tests in unrelated modules, not by our changes. Thank you very much for your time and guidance — it is genuinely appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
