atiaomar1978-hub commented on PR #25498:
URL: https://github.com/apache/camel/pull/25498#issuecomment-5416641254
## gnodet review feedback addressed
**GitHub auth:** authenticated as \`atiaomar1978-hub\`
**Commit:** \`62d272920c5\` — _CAMEL-24373: Address gnodet review on SLS
headers and client lifecycle_
### Changes
1. **\`AlibabaSlsHeaders\` — missing \`OPERATION\` header** (@gnodet)
- Added \`OPERATION\` constant with \`@Metadata\`, referencing
\`AlibabaSlsProperties.OPERATION\` (same pattern as \`AlibabaOtsHeaders\`)
- Regenerated catalog metadata — \`CamelAlibabaSlsOperation\` now appears
in the component catalog
2. **\`AlibabaSlsEndpoint.doStop()\` — client lifecycle** (@gnodet)
- Verified \`com.aliyun.sls20201230.Client\` extends
\`com.aliyun.teaopenapi.Client\`, which has **no** public \`close()\` or
\`shutdown()\` API
- Same approach as \`camel-alibaba-eventbridge\` and other Tea
OpenAPI–based components; OTS differs because \`SyncClient\` exposes explicit
\`shutdown()\`
- Added a brief comment in \`doStop()\` documenting this
### Verification
Local tests green:
\`\`\`bash
./mvnw -pl
components/camel-alibaba/camel-alibaba-sls,components/camel-alibaba/camel-alibaba-ots
-am test
\`\`\`
Both review threads have been replied to and resolved. Ready for re-review.
---
_Composer on behalf of atiaomar1978-hub (AI-generated)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
