gnodet commented on code in PR #26194:
URL: https://github.com/apache/camel/pull/26194#discussion_r3957328602
##########
components/camel-ai/camel-tensorflow-serving/src/main/java/org/apache/camel/component/tensorflow/serving/TensorFlowServingConstants.java:
##########
@@ -24,10 +24,17 @@
public interface TensorFlowServingConstants {
@Metadata(description = "The target of the client. See:
https://grpc.github.io/grpc-java/javadoc/io/grpc/Grpc.html#newChannelBuilder%28java.lang.String,io.grpc.ChannelCredentials%29";,
- javaType = "String")
+ javaType = "String",
+ deprecationNote = "Never read by the component. The gRPC channel
is built once when the endpoint is"
+ + " initialised, so it cannot be redirected
per exchange. Use the target endpoint option.")
+ @Deprecated
Review Comment:
⚠️ **NOT addressed from previous review:** The `@deprecated` Javadoc tag is
still missing. Java convention requires both `@Deprecated` (annotation, for the
compiler) and `@deprecated` (Javadoc, for documentation tooling). Without the
Javadoc tag, generated API docs will show the deprecation flag but not explain
why or what to use instead.
```suggestion
/**
* @deprecated Never read by the component. The gRPC channel is built
once when the endpoint is
* initialised, so it cannot be redirected per exchange. Use the {@code
target} endpoint option.
*/
@Deprecated
```
##########
components/camel-ai/camel-tensorflow-serving/src/main/java/org/apache/camel/component/tensorflow/serving/TensorFlowServingConstants.java:
##########
@@ -24,10 +24,17 @@
public interface TensorFlowServingConstants {
@Metadata(description = "The target of the client. See:
https://grpc.github.io/grpc-java/javadoc/io/grpc/Grpc.html#newChannelBuilder%28java.lang.String,io.grpc.ChannelCredentials%29";,
- javaType = "String")
+ javaType = "String",
+ deprecationNote = "Never read by the component. The gRPC channel
is built once when the endpoint is"
+ + " initialised, so it cannot be redirected
per exchange. Use the target endpoint option.")
+ @Deprecated
String TARGET = "CamelTensorFlowServingTarget";
- @Metadata(description = "The credentials of the client.", javaType =
"io.grpc.ChannelCredentials")
+ @Metadata(description = "The credentials of the client.", javaType =
"io.grpc.ChannelCredentials",
+ deprecationNote = "Never read by the component. The gRPC channel
is built once when the endpoint is"
+ + " initialised, so it cannot be
re-authenticated per exchange. Use the credentials"
+ + " endpoint option.")
+ @Deprecated
Review Comment:
⚠️ **NOT addressed from previous review:** Same issue — `@deprecated`
Javadoc tag missing.
```suggestion
/**
* @deprecated Never read by the component. The gRPC channel is built
once when the endpoint is
* initialised, so it cannot be re-authenticated per exchange. Use the
{@code credentials} endpoint option.
*/
@Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
