oscerd commented on code in PR #26194:
URL: https://github.com/apache/camel/pull/26194#discussion_r3957446738
##########
components/camel-ai/camel-tensorflow-serving/src/main/java/org/apache/camel/component/tensorflow/serving/TensorFlowServingConstants.java:
##########
@@ -24,10 +24,17 @@
public interface TensorFlowServingConstants {
@Metadata(description = "The target of the client. See:
https://grpc.github.io/grpc-java/javadoc/io/grpc/Grpc.html#newChannelBuilder%28java.lang.String,io.grpc.ChannelCredentials%29";,
- javaType = "String")
+ javaType = "String",
+ deprecationNote = "Never read by the component. The gRPC channel
is built once when the endpoint is"
+ + " initialised, so it cannot be redirected
per exchange. Use the target endpoint option.")
+ @Deprecated
Review Comment:
Added — both constants now carry an `@deprecated` Javadoc tag alongside the
annotation, explaining why the header cannot work and pointing at the `target`
/ `credentials` endpoint options (and `toD` where the destination varies per
message). Pushed in e2dfdc9.
_Claude Code on behalf of oscerd_
##########
components/camel-ai/camel-tensorflow-serving/src/main/java/org/apache/camel/component/tensorflow/serving/TensorFlowServingConstants.java:
##########
@@ -24,10 +24,17 @@
public interface TensorFlowServingConstants {
@Metadata(description = "The target of the client. See:
https://grpc.github.io/grpc-java/javadoc/io/grpc/Grpc.html#newChannelBuilder%28java.lang.String,io.grpc.ChannelCredentials%29";,
- javaType = "String")
+ javaType = "String",
+ deprecationNote = "Never read by the component. The gRPC channel
is built once when the endpoint is"
+ + " initialised, so it cannot be redirected
per exchange. Use the target endpoint option.")
+ @Deprecated
String TARGET = "CamelTensorFlowServingTarget";
- @Metadata(description = "The credentials of the client.", javaType =
"io.grpc.ChannelCredentials")
+ @Metadata(description = "The credentials of the client.", javaType =
"io.grpc.ChannelCredentials",
+ deprecationNote = "Never read by the component. The gRPC channel
is built once when the endpoint is"
+ + " initialised, so it cannot be
re-authenticated per exchange. Use the credentials"
+ + " endpoint option.")
+ @Deprecated
Review Comment:
Added — both constants now carry an `@deprecated` Javadoc tag alongside the
annotation, explaining why the header cannot work and pointing at the `target`
/ `credentials` endpoint options (and `toD` where the destination varies per
message). Pushed in e2dfdc9.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
