davsclaus commented on code in PR #26783:
URL: https://github.com/apache/camel/pull/26783#discussion_r4083550912
##########
components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/utils/message/PulsarMessageHeaders.java:
##########
@@ -60,4 +60,7 @@ public interface PulsarMessageHeaders {
@Metadata(label = "producer", description = "Deliver the message after a
given delayed time (millis).",
javaType = "Long")
String DELIVER_AFTER = "CamelPulsarProducerMessageDeliverAfter";
+ @Metadata(label = "producer", description = "The message id the broker
assigned to the published message.",
+ javaType = "org.apache.pulsar.client.api.MessageId")
+ String MESSAGE_ID_OUT = "CamelPulsarProducerMessageId";
Review Comment:
Nit: in this file the other `*_OUT` constants (`KEY_OUT`, `EVENT_TIME_OUT`,
...) are values the producer *reads*, while this one is a result the producer
*writes*. A name like `PRODUCER_MESSAGE_ID` would make that clearer. Not
blocking.
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -2534,6 +2534,17 @@ was published as a second, undocumented spelling of the
same setting. Routes tha
`databaseOutServerName` should use `xstreamOutServerName` instead; it
configures the same XStream outbound
server and is unchanged.
+=== camel-pulsar - the producer no longer replaces the body with the message id
Review Comment:
Nit: this entry lands in the middle of the file (the branch was based on an
older main). Optionally, move it to the end and mention that the old behaviour
dates from 3.20 (CAMEL-16030).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
