oscerd commented on code in PR #26783:
URL: https://github.com/apache/camel/pull/26783#discussion_r4084317681
##########
components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/utils/message/PulsarMessageHeaders.java:
##########
@@ -60,4 +60,7 @@ public interface PulsarMessageHeaders {
@Metadata(label = "producer", description = "Deliver the message after a
given delayed time (millis).",
javaType = "Long")
String DELIVER_AFTER = "CamelPulsarProducerMessageDeliverAfter";
+ @Metadata(label = "producer", description = "The message id the broker
assigned to the published message.",
+ javaType = "org.apache.pulsar.client.api.MessageId")
+ String MESSAGE_ID_OUT = "CamelPulsarProducerMessageId";
Review Comment:
Good distinction, renamed to `PRODUCER_MESSAGE_ID`. The header value is
unchanged (`CamelPulsarProducerMessageId`); only the Java constant moves, so
the catalog picks up the new `constantName`. Regenerating now.
_Claude Code on behalf of oscerd_
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -2534,6 +2534,17 @@ was published as a second, undocumented spelling of the
same setting. Routes tha
`databaseOutServerName` should use `xstreamOutServerName` instead; it
configures the same XStream outbound
server and is unchanged.
+=== camel-pulsar - the producer no longer replaces the body with the message id
Review Comment:
The 3.20 provenance is a good addition — verified and added: CAMEL-16030
("camel-pulsar - Add async send to producer", fixed 3.20.0) is where the
`thenAccept(r -> setBody(r))` came in.
On the position: that one is deliberate rather than base drift. I have three
open PRs that each add an entry to this guide, and appending all of them at the
end guarantees a conflict for whichever merges second — it already cost #26733
a rebase today. Putting this one before an existing section keeps the hunks
apart so git merges them cleanly. Happy to move it to the end if you would
rather the file stayed strictly append-ordered; it is a one-line change either
way.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
