ramu11 commented on code in PR #27168: URL: https://github.com/apache/camel/pull/27168#discussion_r4154137261
########## components/camel-odata/src/main/java/org/apache/camel/component/odata/ODataHelper.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.odata; + +import java.util.List; +import java.util.Map; + +import org.apache.camel.util.json.DeserializationException; +import org.apache.camel.util.json.Jsoner; + +public final class ODataHelper { + + private ODataHelper() { + } + + public static String toJson(Object value) { + if (value == null) { + return null; + } + + if (value instanceof String string) { + return string; + } + + return Jsoner.serialize(value); + } + + @SuppressWarnings("unchecked") + public static Map<String, Object> parseJsonObject(String value) throws DeserializationException { + if (value == null || value.isBlank()) { + return Map.of(); + } + + Object parsed = Jsoner.deserialize(value); + if (!(parsed instanceof Map)) { + throw new IllegalArgumentException("Expected an OData JSON object response"); + } + + return (Map<String, Object>) parsed; + } + + @SuppressWarnings("unchecked") + public static List<Map<String, Object>> extractValueList(Map<String, Object> response) { + Object value = response.get("value"); + + if (!(value instanceof List)) { + throw new IllegalArgumentException("OData response does not contain a value array"); + } + + return (List<Map<String, Object>>) value; + } Review Comment: Addressed in the latest commit `4cb8cea36f16`. `extractValueList()` was unused, so it has been removed from `ODataHelper` rather than adding unnecessary usage to `ODataProducer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
