gnodet-bot commented on code in PR #27168:
URL: https://github.com/apache/camel/pull/27168#discussion_r4154434061
##########
components/camel-odata/src/main/docs/odata-component.adoc:
##########
@@ -0,0 +1,408 @@
+= OData Component
+:doctitle: OData
+:shortname: odata
+:artifactid: camel-odata
+:description: Camel OData Component
+:since: 4.23
+:supportlevel: Preview
+:tabs-sync-option:
+:component-header: Only producer is supported
+
+*Since Camel {since}*
+
+*{component-header}*
+
+The OData component allows you to interact with OData V4 services using
standard OData CRUD operations.
+
+The component provides OData-specific request and response handling while
using Camel HTTP as the underlying HTTP transport.
+
+The OData component is the successor to the deprecated `camel-olingo4`
component.
+
+The component supports OData V4 services using JSON representations.
+
+Maven users will need to add the following dependency to their `pom.xml` for
this component:
+
+[source,xml]
+
+<dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-odata</artifactId>
+ <version>x.x.x</version>
+ <!-- use the same version as your Camel core version -->
+</dependency>
+----
Review Comment:
🔴 **AsciiDoc — every listing block is missing its opening `----` delimiter.**
The current pattern throughout the file is:
```
[source,xml]
<dependency>
...
</dependency>
----
```
But valid AsciiDoc listing blocks **require both delimiters**:
```
[source,xml]
----
<dependency>
...
</dependency>
----
```
This is exactly what the Antora CI reports as `unterminated listing block`
at line 29 (see [apupier's
comment](https://github.com/apache/camel/pull/27168#issuecomment-3029003700)).
The missing opening `----` causes AsciiDoc to treat the closing `----` as the
*opening*, and then everything after it becomes code until the next delimiter —
cascading through the rest of the document.
This affects **all ~18 code blocks** in the file (lines 25, 43, 106, 114,
195, 241, 253, 261, 280, 300, 316, 336, 348, 358, 364, 376, 392). Each
`[source,...]` must be followed immediately by `----` on the next line (no
blank line between them).
Additionally, line 312 has a single `-` instead of `----` as its closing
delimiter.
The fix is mechanical: insert `----` after each `[source,...]` line
(removing the blank line), and fix the single `-` at line 312 to `----`.
This is the same class of issue that was raised in prior reviews (the `##
[source,...]` Markdown prefix) — the prefix was removed, but the opening
delimiter was not added back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
