michalvavrik commented on code in PR #6851:
URL: https://github.com/apache/camel-k/pull/6851#discussion_r4166068237
##########
pkg/trait/knative_test.go:
##########
@@ -1326,46 +1316,35 @@ func newFakeClient(namespace string) (client.Client,
error) {
if err != nil {
return nil, err
}
- brokerURL, err := apis.ParseURL("http://broker-default.host/";)
- if err != nil {
- return nil, err
- }
+ // The Channel and Broker resources are only read as unstructured
objects
Review Comment:
> Why? wouldn't it be possible to use the duck type instead?
Because operator doesn't use them and this is test only code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
