davsclaus commented on code in PR #27201:
URL: https://github.com/apache/camel/pull/27201#discussion_r4171972928
##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MiloClientConnection.java:
##########
@@ -118,15 +118,16 @@ public interface MonitorHandle {
}
public MonitorHandle monitorValue(
- final ExpandedNodeId nodeId, Double samplingInterval, final
Consumer<DataValue> valueConsumer) {
+ final ExpandedNodeId nodeId, Double samplingInterval, Integer
queueSize, final Consumer<DataValue> valueConsumer) {
requireNonNull(configuration);
requireNonNull(valueConsumer);
checkInit();
final UInteger handle
- = this.manager.registerItem(nodeId, samplingInterval,
valueConsumer, this.monitorFilterConfiguration);
+ = this.manager.registerItem(nodeId, samplingInterval,
queueSize, valueConsumer,
+ this.monitorFilterConfiguration);
Review Comment:
`this.monitorFilterConfiguration` belongs to the shared connection (cached
by server URI plus `clientId`), so every endpoint on this connection gets the
first endpoint's filter. Please pass the endpoint's filter in as a parameter of
`monitorValue`, like `samplingInterval` and `queueSize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
