ramu11 commented on PR #27314: URL: https://github.com/apache/camel/pull/27314#issuecomment-6062010051
> Thanks @ramu11, the review feedback is in good shape. I resolved the conversations that are addressed in the latest commit. Three remain open: > > 1. **Jakarta Persistence 4 taking over:** `camel-hibernate` is still added to `camel-allcomponents` without an exclusion, so `jakarta.persistence-api` 4.0.0-M7 can still win over the version `camel-jpa` uses there and in the `apache-camel` distribution. > 2. **A failing row blocks the consumer:** the exchange leak is fixed, but a failing entity still rolls back the whole batch and is picked up again on the next poll. If that is intended (`camel-jpa` behaves the same way), a short note in the docs is enough. > 3. **`parent/pom.xml` leftover:** the `hibernate8-version` property in the parent is no longer used, because the module pom defines it itself. Please remove it from the parent. > > We plan to take this up for 4.24, together with the upgrades of Quarkus and the other platforms. By then the Hibernate 8 / Jakarta Persistence 4 picture should also be clearer. > > _Claude Code on behalf of davsclaus_ Thanks for the review. I’ve addressed all three comments: Kept <supportLevel>Preview</supportLevel> for the Hibernate 8 pre-release dependency. Updated the natural-id documentation to clarify that individual naturalId.* values do not resolve #bean references, while naturalIdParameters=#bean is supported. The existing consumer documentation already covers the transactional batch behavior: a failing entity rolls back the current poll, previously processed entities may be picked up again on a subsequent poll, and a consistently failing entity can prevent later rows from being processed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
