davsclaus commented on code in PR #27314:
URL: https://github.com/apache/camel/pull/27314#discussion_r4227328380
##########
parent/pom.xml:
##########
@@ -1695,6 +1695,17 @@
<artifactId>camel-hazelcast</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-hibernate</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.persistence</groupId>
+ <artifactId>jakarta.persistence-api</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Thanks for looking into the Jakarta Persistence overlap. My earlier comment
hinted at an exclusion, but unfortunately it can't live here. This entry is in
the `<!-- camel components: START/END -->` block, which
`camel-package-maven-plugin` (`PrepareComponentMojo`) rewrites from
groupId/artifactId/version on every component build, so the exclusion is
dropped again. The generated block in `catalog/camel-allcomponents/pom.xml`
behaves the same way. CI's full regen now fails on this commit with an NPE in
`camel-package-maven-plugin:generate` (`"before" is null`), and it was green on
34533f2. Even if the exclusion stayed, it would only move the problem:
`camel-allcomponents` and the distribution would ship `camel-hibernate`, built
against Jakarta Persistence 4.0.0-M7, next to 3.2.0. Please remove it again.
While camel-jpa and camel-hibernate are on different Jakarta Persistence
versions there is no build-level fix, which is why this stays the open point
for 4.24.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
