allthingssecurity commented on PR #27590: URL: https://github.com/apache/camel/pull/27590#issuecomment-6071947476
On `getDecodeQuery`: it is not display-only. `git grep` finds one production caller, `AbstractCamelContext.removeEndpoints` (line 727), which uses it to look up the registry key of an encoded uri, so the split could remove the wrong endpoint (the encoded uri of `stub:foo?a=RAW(x y)&b=Tom%26Jerry` removed `stub:foo?a=RAW(x y)&b=Tom&Jerry=`). Fixed in 4b3fcf377d17: `parseParameters`, `normalizeUri` and `getDecodeQuery` share one helper now, with `testGetDecodeQueryEncodedAmpersand` and a `removeEndpoints` test in `EndpointUriEncodedAmpersandTest` that both fail with the previous `getDecodeQuery`; camel-util 297 tests pass. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
