oscerd commented on PR #27718:
URL: https://github.com/apache/camel/pull/27718#issuecomment-6123748142

   > **Finding 1** — camel-netty-http
   
   Good catch, addressed in f1a1bf6e9b95:
   
   * camel-netty-http is now a recognised type: the processors read the headers 
of `NettyHttpMessage#getHttpRequest()`.
   * A list of transports cannot be complete, though: camel-undertow builds a 
plain `DefaultMessage`, so its HTTP request cannot be reached from the route at 
all. For any message that gives no access to the HTTP request, 
`HttpRequestHeaders` now reads the message headers but leaves out a value that 
also appears in the query string of the request (`CamelHttpRawQuery`, else 
`CamelHttpQuery`, compared raw and decoded; a query string that cannot be 
decoded leaves out every value). That covers undertow and any other consumer 
without depending on the list.
   * What remains on such consumers is a value that comes from a form field. 
For the bearer token that only authenticates the request that carries it, since 
the processor no longer touches the session; for the session cookie it only 
applies to that one request.
   * Tests: `OAuthRequestHeadersNettyHttpTest` and 
`OAuthRequestHeadersUndertowTest` run the shared cases on both consumers. On 
undertow the form-field case is skipped, and an extra case checks that a header 
value which the query string also holds is not read. `HttpRequestHeadersTest` 
covers the fallback itself.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to