oscerd commented on PR #27718:
URL: https://github.com/apache/camel/pull/27718#issuecomment-6128404955
Thanks for the review, addressed in d15af1713395:
1. **platform-http on Spring Boot**: good catch, and the description claimed
it was covered.
* `HttpRequestHeaders` now matches
`org.apache.camel.component.platform.http.springboot.PlatformHttpMessage` by
class name. It reads the `HttpServletRequest` that the message holds in the
`CamelHttpServletRequest` header with the servlet reader, after checking that
the header really holds one. A form field of the same name is therefore no
longer read there, and no camel-spring-boot dependency is needed.
* camel-spring-boot is not a dependency here, so `HttpRequestHeadersTest`
uses a stand-in class of the same name in the test sources, with a proxy
`HttpServletRequest`. Breaking the class name match turns those tests red.
2. **Upgrade guide**: added your `X-Forwarded-Access-Token` example. On the
consumers whose request is read, an `Authorization` or `Cookie` header that the
route sets itself is not used either; such routes can use
`OAuthHelper.validateOAuthToken` instead. The guide also notes that the bearer
processor no longer sets `CamelOAuthSessionId`, lists Spring Boot with the
consumers whose request is read, and gives camel-undertow as the example of the
fallback.
3. **Diagnostics**: `HttpRequestHeaders` now logs at DEBUG why a message
header value was left out (the query string holds it, or cannot be decoded),
without logging the value.
4. **4.22.x / 4.18.x upgrade guides**: agreed, they are needed. I'll add the
4.22.2 and 4.18.6 entries on main together with the backports, once those are
merged and `gh api compare` confirms which patch release they actually land in.
On 10-11, 4.18.5 was cut before four backports merged, and their notes had to
be moved afterwards.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
