oscerd commented on PR #27777:
URL: https://github.com/apache/camel/pull/27777#issuecomment-6163661179
The `build (17, false)` failure here is a compile error, not a flake:
```
TelegramServiceRestBotAPIAdapterErrorTest.java:[74,40] constructor
TelegramAsyncHandler in class ... cannot be applied to given types;
required: String, Class<? extends MessageResult>, ObjectMapper, Exchange,
AsyncCallback
found: String, Class<MessageResult>, ObjectMapper, DefaultExchange
```
#27716 sits on CAMEL-25577 (#27761), which removed the `AsyncCallback` from
`TelegramAsyncHandler`. CAMEL-25577 is on `main` only (fixVersion 4.24.0), so
on `camel-4.22.x` the handler still takes the callback. Two smaller things in
this PR also depend on #27761:
- The Javadoc it adds to `handleCompressedResponse` ("the caller fails the
exchange with that exception and completes it") describes #27761's behaviour.
On 4.22.x the handler still completes the callback itself.
- The note in `camel-4x-upgrade-guide-4_22.adoc` is already on `main`, where
the guides for every line live, so the backport does not need it.
#27781 is the same backport with these handled: the request description is
applied to the 4.22.x handler, the test passes a callback, and there is no
guide change. Its reactor is green on `camel-4.22.x` and camel-telegram has
105/105. Its only CI failure was the known `LumberjackMultiThreadIT` flake, and
a re-run is queued.
So, correcting what I offered on #27778: I would keep #27781 and close this
one, unless you prefer to take the two fixes from #27781 into this branch.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
