Croway commented on PR #27777:
URL: https://github.com/apache/camel/pull/27777#issuecomment-6167206043

   @gnodet @oscerd: #27777 and #27781 are both open and backport the same 
change (#27716, CAMEL-25564) to `camel-4.22.x`. Only one of them should be 
merged, so could one of you close the other?
   
   What differs between the two:
   
   - **#27777** (bot cherry-pick) fails `testCompile` in `camel-telegram`. 
`TelegramServiceRestBotAPIAdapterErrorTest` calls the four-argument 
`TelegramAsyncHandler` constructor, which exists only on `main` after 
CAMEL-25577 (#27761). `camel-4.22.x` still has the five-argument constructor 
with `AsyncCallback` ([failed 
run](https://github.com/apache/camel/actions/runs/38391985713)). It also adds 
the upgrade-guide note on the maintenance branch, but that note is already on 
`main` in `camel-4x-upgrade-guide-4_22.adoc`.
   - **#27781** adapts the handler and the test to the 4.22.x constructor and 
leaves the upgrade guide out. Its description lists these changes, so it needs 
a normal review.
   
   There's also a CI cost. Both PRs touch `core/camel-util`, and on 
`camel-4.22.x` that currently makes CI test ~590 modules (#27781's run has been 
in `mvn test` for ~1.5h). #27829 backports the threshold fix from `main`. After 
it is merged, the open 4.22.x backport that remains needs a new push, or a 
close and reopen, to pick up the fixed script. A plain re-run would reuse the 
old merge commit.
   
   _Claude Code on behalf of Croway_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to