allthingssecurity commented on PR #28202: URL: https://github.com/apache/camel/pull/28202#issuecomment-6310382935
On the bot's point: fixed in ea30b066ae16. `fetchNewEvents` now returns an empty list when the first page is null, so callers never get null. I checked that it can happen: the admin client (26.0.12, RESTEasy 6.2.15) returns null from `getEvents`/`getAdminEvents` for a 2xx response without a content type, such as a 204. A Keycloak server itself answers with a JSON array, so this is an edge case. Main had the same NPE, since it iterated the result of `getEvents()` directly. In the scheduler, `ScheduledPollConsumer` catches the NPE and logs it, so the poll fails but the consumer keeps running. New test `aResponseWithoutContentIsAPollWithoutEvents` (mocked client returns null) fails with the NPE without the change. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
