allthingssecurity commented on PR #28325: URL: https://github.com/apache/camel/pull/28325#issuecomment-6361676098
@davsclaus thanks, addressed in 5754d348428b: 1. The own channel is counted after a successful connect (your inline suggestion). Test `aProducerWhoseConnectFailedDoesNotKeepTheChannelConnected` fails with the count before the connect. 2. The own-channel `connect()`/`disconnect()` now run under a lock of the endpoint, like the shared path under the component's lock. Test `aConsumerThatStartsWhileTheProducerStopsKeepsTheChannelConnected` holds the producer's disconnect until the starting consumer waits on the lock, and fails without the lock. `resolveChannel()` is package-private for these tests (new `JGroupsEndpointOwnChannelTest`). 3. User-supplied channels closed at component stop: kept as on main in this PR. I drafted a follow-up JIRA to disconnect rather than close the channels Camel did not create (with an upgrade-guide note). Tests (offline, `-DskipITs`): camel-jgroups unit tests 33 run, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
