allthingssecurity commented on PR #28325: URL: https://github.com/apache/camel/pull/28325#issuecomment-6362536333
@davsclaus thanks for the approval. 1. The description mentions the endpoint lock, the new `JGroupsEndpointOwnChannelTest` (with both tests and their failure messages), that `resolveChannel()` is package-private, and 33 tests run. 2. The follow-up JIRA for the user-supplied channel (disconnect instead of close at component stop) is drafted. It will be linked from CAMEL-25852 once it is filed. 3. Done in 06c6a7d853ee: `connectCount` is a plain `int` under `connectLock`, and the Javadoc of `connect()`/`disconnect()` no longer says "shared channel". No change in behaviour; the camel-jgroups unit tests pass (33, 0 failures). On the backport note from gnodet-bot: I cannot set labels on apache/camel. The connect/disconnect/close code this PR changes (`JGroupsEndpoint.connect/disconnect/doStop`, `JGroupsConsumer.doStop`, `JGroupsProducer`) is the same on `camel-4.22.x` and `camel-4.18.x` as on main; the files differ there only in the deserialization start-up guard (`acceptAllObjects`), which the two consumer-fails-to-start tests use, so a backport would need those two tests adapted. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
