davsclaus commented on code in PR #28351:
URL: https://github.com/apache/camel/pull/28351#discussion_r4359342215
##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpSecurityConfiguration.java:
##########
@@ -113,4 +114,12 @@ public void setLoginDeniedLoggingLevel(LoggingLevel
loginDeniedLoggingLevel) {
this.loginDeniedLoggingLevel = loginDeniedLoggingLevel;
}
+ public NettyHttpSecurityConfiguration copy() {
Review Comment:
Non-blocking: a javadoc line would make clear that this is a shallow copy.
The `SecurityConstraint` and `SecurityAuthenticator` instances stay shared with
the original.
```suggestion
/**
* Creates a shallow copy of this configuration, so an endpoint can
change its own options without affecting the
* component or other endpoints. The {@link SecurityConstraint} and
{@link SecurityAuthenticator} instances are
* shared with the original.
*/
public NettyHttpSecurityConfiguration copy() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
