gnodet-bot commented on code in PR #28351:
URL: https://github.com/apache/camel/pull/28351#discussion_r4359329040
##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpSecurityConfiguration.java:
##########
@@ -113,4 +114,12 @@ public void setLoginDeniedLoggingLevel(LoggingLevel
loginDeniedLoggingLevel) {
this.loginDeniedLoggingLevel = loginDeniedLoggingLevel;
}
+ public NettyHttpSecurityConfiguration copy() {
Review Comment:
💡 **Suggestion:** Consider adding a Javadoc comment to document the
shallow-copy semantics. `clone()` copies field references rather than
deep-cloning them, so `SecurityAuthenticator` and `SecurityConstraint`
instances will be shared across copies. Worth calling out:
```suggestion
/**
* Creates a shallow copy of this security configuration.
* Note: {@code SecurityAuthenticator} and {@code SecurityConstraint}
references
* are shared between the original and the copy.
*
* @return a new {@code NettyHttpSecurityConfiguration} with the same
field values
*/
public NettyHttpSecurityConfiguration copy() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
