gnodet-bot commented on code in PR #28746:
URL: https://github.com/apache/camel/pull/28746#discussion_r4429259006
##########
dsl/camel-jbang/camel-jbang-run/pom.xml:
##########
@@ -29,10 +29,10 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>camel-jbang-export</artifactId>
+ <artifactId>camel-jbang-run</artifactId>
<packaging>jar</packaging>
- <name>Camel :: JBang :: Export</name>
+ <name>Camel :: JBang :: Run</name>
<description>Camel CLI Export: create a Maven project of a Camel
integration, without picocli or jline</description>
Review Comment:
💬 **Stale description:** `<artifactId>` and `<name>` were updated to reflect
the rename, but `<description>` still says "Camel CLI Export" instead of
something describing the run use-case.
```suggestion
<description>Camel CLI Run: run a Camel integration, without picocli or
jline</description>
```
##########
.github/workflows/camel-launcher-native-exe.yml:
##########
@@ -91,7 +91,7 @@ jobs:
# camel-launcher-native normally resolves camel-jbang-core (and the
launcher's other
# in-repo dependencies) from the Apache Snapshots repo instead of
building them here (see
# the "Build launcher with native camel.exe" step below). That
assumption breaks when a PR
- # changes camel-jbang-core or camel-jbang-export (which
camel-jbang-core depends on)
+ # changes camel-jbang-core or camel-jbang-run (which
camel-jbang-core depends on)
# itself, since the new code isn't on the snapshot repo yet.
if echo "$CHANGED" | grep -qE
'^dsl/camel-jbang/camel-jbang-(core|export)/'; then
camel_launcher_upstream=true
Review Comment:
⚠️ **Stale grep pattern:** The comment on line 94 was updated to mention
`camel-jbang-run`, but the actual grep pattern on this line still matches
`camel-jbang-export`. Changes to `dsl/camel-jbang/camel-jbang-run/` will never
satisfy this condition, so the source-install step will be skipped on PRs that
touch `camel-jbang-run` but not `camel-jbang-core`.
```suggestion
if echo "$CHANGED" | grep -qE
'^dsl/camel-jbang/camel-jbang-(core|run)/'; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
