davsclaus commented on code in PR #28746:
URL: https://github.com/apache/camel/pull/28746#discussion_r4429287169
##########
.github/workflows/camel-launcher-native-exe.yml:
##########
@@ -91,7 +91,7 @@ jobs:
# camel-launcher-native normally resolves camel-jbang-core (and the
launcher's other
# in-repo dependencies) from the Apache Snapshots repo instead of
building them here (see
# the "Build launcher with native camel.exe" step below). That
assumption breaks when a PR
- # changes camel-jbang-core or camel-jbang-export (which
camel-jbang-core depends on)
+ # changes camel-jbang-core or camel-jbang-run (which
camel-jbang-core depends on)
# itself, since the new code isn't on the snapshot repo yet.
if echo "$CHANGED" | grep -qE
'^dsl/camel-jbang/camel-jbang-(core|export)/'; then
camel_launcher_upstream=true
Review Comment:
_Claude Code on behalf of davsclaus_
Good catch, thanks: the alternation `(core|export)` was not found by the
rename, and it is the only one. Fixed in a29473a6a968:
`^dsl/camel-jbang/camel-jbang-(core|run)/`.
##########
dsl/camel-jbang/camel-jbang-run/pom.xml:
##########
@@ -29,10 +29,10 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>camel-jbang-export</artifactId>
+ <artifactId>camel-jbang-run</artifactId>
<packaging>jar</packaging>
- <name>Camel :: JBang :: Export</name>
+ <name>Camel :: JBang :: Run</name>
<description>Camel CLI Export: create a Maven project of a Camel
integration, without picocli or jline</description>
Review Comment:
_Claude Code on behalf of davsclaus_
Thanks, fixed in a29473a6a968: `Camel CLI Run: export a Camel integration to
a Maven project, and run it, without picocli or jline`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
