allthingssecurity commented on PR #28779: URL: https://github.com/apache/camel/pull/28779#issuecomment-6555697250
Thanks for the review. Changes are in 9a290cc. 1. The description now states the cost correctly. The advice has state, and a route with no other stateful advice (JMX off, no backlog tracer standby, no pooled exchange factory) used `EMPTY_STATES` before. It now allocates a `new Object[1]` per route entry, next to the `AsyncAfterTask`. No code change. 2. New `ResilienceCalledRouteRoutingSlipTest` in camel-resilience4j. A route called from `circuitBreaker()` has a routing slip with `maximumRedeliveries(2)`: the first step gets 1 delivery and the failing step 1 + 2. With the `CamelInternalProcessor` of main the whole slip is redelivered (the first step gets 3), so the test fails. It lives here instead of #28780 because it needs this change; #28780 says so too. I'll post the `/component-test` comment separately. 3. I changed the PR title to your wording, so the squash commit can use it. 4. `@Timeout(10)` is now on `DoTryCalledRouteErrorHandlerTest`, replacing the `assertTimeoutPreemptively` in `check()`. I kept the `getReceivedCounter()` assertions. Tests: `DoTryCalledRouteErrorHandlerTest` (10 of 19 fail on main) and the new class, each 20 times in one JVM (400 tests). The camel-core doTry/doCatch/doFinally, routing slip, recipient list, dynamic router and multicast tests (456) and camel-resilience4j (86) all pass, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
