gnodet-bot commented on code in PR #28779: URL: https://github.com/apache/camel/pull/28779#discussion_r4434970207
########## components/camel-resilience4j/src/test/java/org/apache/camel/component/resilience4j/ResilienceCalledRouteRoutingSlipTest.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.resilience4j; + +import java.util.concurrent.atomic.AtomicInteger; + +import org.apache.camel.Exchange; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.test.junit6.CamelTestSupport; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; + +/** + * A route called from the steps of a circuit breaker uses the error handler of its routing slip (CAMEL-26421). + */ +class ResilienceCalledRouteRoutingSlipTest extends CamelTestSupport { Review Comment: ⚠️ **Missing `@Timeout(10)`** — `DoTryCalledRouteErrorHandlerTest` just received this annotation with the comment 'a regression that hangs a send fails the test instead of blocking the build'. The same risk applies here: `template.send("direct:start", ...)` can hang indefinitely if the routing-slip-in-called-route dispatch regresses. Please add: ```suggestion // a regression that hangs a send fails the test instead of blocking the build @Timeout(10) class ResilienceCalledRouteRoutingSlipTest extends CamelTestSupport { ``` Also add `import org.junit.jupiter.api.Timeout;` to the import block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
