Jinal-Sarvaiya commented on code in PR #149:
URL: https://github.com/apache/camel-kit/pull/149#discussion_r4454905358
##########
kit/camel-kit-core/src/test/java/org/apache/camel/kit/ship/controller/OpenCodeNativeWorkerTest.java:
##########
@@ -0,0 +1,15 @@
+package org.apache.camel.kit.ship.controller;
+
+import org.apache.camel.kit.ship.controller.ShipRun.ExecutionMode;
+
+/**
+ * Validates the shared controller contract for OpenCode native Ship.
Generated assets were verified via a local
Review Comment:
The controller lifecycle contract is fully exercised by
OpenCodeNativeWorkerTest (24/24 pass on Linux aarch64) and ShipNativeWorkerTest
(24/24 pass on Linux aarch64), covering:
- Oversight pauses at configured gates
- Recovery after parent/child interruption through durable state
- Abort/timeout via cross-controller AbortWatcher
- Idempotent submission guards preventing re-execution
- Rejection of stale/conflicting results through schema version and
run-state validation
- Deterministic artifact hash verification
- File write restrictions to approved candidate workspace only
- MCP tool denial (worker receives only read/search tools)
Additional passing tests: ShippedAssetStructureTest (9/9),
OpenCodeGeneratorTest (38/38), ShipStageResultTest (10/10), ShipCommandTest
(70/71, 1 pre-existing Docker root permission failure), sourcecheck — all on
Linux.
Live evidence (Nov 2, Linux aarch64 / OpenCode 2.2.5): DISCOVERY run through
camel-ship-worker returned valid schema v2 JSON; MCP tool denial confirmed with
worker receiving only read/search tools.
The remaining host-level evidence — completed workflow through the
registered generated Ship entry point (camel-ship/SKILL.md → camel kit ship
--backend opencode-native --json), and verification of the subagent/agent vs
task/subagent_type relay for OpenCode 2.2.5 — is blocked by an extended EnMaaS
outage (api.enmaas.devshift.net returning 503, all OpenShift pods down). Will
provide this evidence when the gateway recovers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
