knockknock10 commented on PR #6922: URL: https://github.com/apache/camel-k/pull/6922#issuecomment-6710711212
> Hi @knockknock10, thanks for this contribution! A quick note on the test failure: your test currently hardcodes the `keda` namespace (`WithExistingNamedTestNamespace` and `ibmmq.keda.svc`), but CI requires isolated dynamic namespaces via `WithNewTestNamespace`. You can use the existing `cloneAndReplaceNamespace` helper in `package keda` with `ibmmq.%%%.svc` in your manifests so KEDA and the integration properly resolve the IBM MQ admin host in the dynamic test namespace. Also, please rebase on `upstream/main` to resolve the current merge conflicts. @ansh0014, did you go through the existing PR discussion before jumping in with these suggestions? `squakez` has already reviewed the changes, discussed the pending points, deliberately moved this PR to draft, and requested `oscerd's` review. The current status is intentional. I'd appreciate it if you checked the existing discussion before assuming what needs to be done next. I'll take this forward once `oscerd` has provided his input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
