WMK666666 commented on PR #29594: URL: https://github.com/apache/camel/pull/29594#issuecomment-6815444772
Point 1 is in: the title is now **camel-docling: return DocTags content and reject html_split_page on docling-serve**. The description point was already handled when the body was rewritten at 16:23Z — it says `mapToOutputFormat` rejects the value (that map is where the format is decided), and `buildConvertRequest` is not mentioned in it any more. The sentence you quoted reads "`mapToOutputFormat` rejects `html_split_page` with the reason, for the same reason the doctags case exists". Point 2 (`outputFormat` still lists `html_split_page` in its `enums`): I left it out of this PR, as you suggested, because it is not just a description change — the option description lives in the `@UriParam` of `DoclingConfiguration`, so the generated metadata (`src/generated/java/.../docling.json` and the catalog copies) has to be regenerated and committed with it, which would add a second concern to a PR that is otherwise two lines of behaviour. It is worth doing: after this PR that value can only produce the error, since `outputFormat` is read only by `SUBMIT_ASYNC_CONVERSION`, which needs docling-serve. Say the word and I will do it here instead of in a follow-up — I would rather you decide than open another PR you have to review. Point 3 (upgrade-guide conflict with #29591/#29595): understood, whichever lands second rebases. #29594's entry is the last one in the `camel-docling` section of `camel-4x-upgrade-guide-4_24.adoc`, and `DoclingProducer.java` no longer overlaps either PR, so only the `docs` file would need the rebase. CI on 1617c89 is still waiting for approval, as you noted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
