WMK666666 commented on PR #29594:
URL: https://github.com/apache/camel/pull/29594#issuecomment-6818611242
Rebased on main (`55f1def`) as well, since #29591 and #29593 are in and this
branch had the same conflict at
the end of the `camel-docling` section of the 4.24 upgrade guide. Both
entries are kept: the `apiKeyHeader`
one from main first, then the `html_split_page` one from this PR.
`DoclingProducer.java` again merged cleanly with #29593's
`BearerTokenDoclingServeClient` selection; the
`html_split_page` rejection in `mapToOutputFormat` is untouched by it.
`DoclingContentExtractor.java` did
not change on main.
Diff is unchanged by the rebase: `+188/-2` over the same five files, one
commit on top of `009cff12`.
Two open items from your last review, for the record:
- The title is now **camel-docling: return DocTags content and reject
html_split_page on docling-serve**, and
the description already says the rejection is in `mapToOutputFormat` (it
was rewritten with the 16:23Z
update; `buildConvertRequest` no longer appears).
- The `outputFormat` `enums` note is still not in this PR, as you allowed.
It needs
`DoclingConfiguration`'s `@UriParam` description plus the regenerated
metadata, so it is a second concern;
if you would rather have it here than in a follow-up, say so and I will
push it on this branch.
CI on the new commit will need approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
