Croway opened a new pull request, #30008:
URL: https://github.com/apache/camel/pull/30008

   JIRA: [CAMEL-26978](https://issues.apache.org/jira/browse/CAMEL-26978)
   
   - Since CAMEL-23997 (4.22.0), `KafkaManualCommit.commit()` with 
`DefaultKafkaManualAsyncCommitFactory` called `commitAsync` on the calling 
thread. After an aggregator, every commit failed with 
`ConcurrentModificationException`, and nothing was committed while the route 
ran.
   - `commit()` now records the offset, and the consumer thread commits the 
requested offsets before its next poll, as in 4.21 and as the docs say. A 
partition that is revoked drops its requested offset. Commits are still made 
only when the route calls `commit()`, as CAMEL-23997 requires.
   - Docs: rewrote the async commit paragraph and the thread note, and removed 
the unfinished "Note 2".
   
   Tests: `DefaultKafkaManualAsyncCommitTest` (a `MockConsumer` that only the 
polling thread may use): a commit after an aggregator fails on main and passes 
now; a commit in the Kafka route still works. 
`KafkaConsumerAsyncManualCommitIT` and the other async commit ITs pass.
   Upgrade guide: 4.24 entry "camel-kafka - the asynchronous manual commit is 
done by the consumer thread".
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to