Croway commented on PR #30008:
URL: https://github.com/apache/camel/pull/30008#issuecomment-6896157041

   @davsclaus
   1. Done in ea233771a8f4: `commitRequestedOffsets()`, which runs on the 
polling thread before `poll()`, now drops a requested offset whose partition is 
not in `consumer.assignment()`, with a DEBUG log. New test 
`DefaultKafkaManualAsyncCommitTest.testCommitAfterRevokeIsNotCommitted`: the 
partition is revoked with `rebalance(List.of())`, then `commit()` is called 
from the test thread, and no commit is made for the partition (it fails without 
the check); the two existing tests stay as the positive cases. The docs and 
both upgrade guides mention it.
   2. Not changed: last-writer-wins is what 4.21 did, and the fix stays a 
minimal port for 4.22.x.
   3. Opened [CAMEL-26993](https://issues.apache.org/jira/browse/CAMEL-26993) 
(relates to CAMEL-26978): with manual commits, `KafkaRecordStreamingProcessor` 
records every processed offset in the `OffsetCache`, and `commit(partition)` on 
revoke and stop commits it, also for records the route did not commit; it notes 
that `breakOnFirstError` relies on the same cache.
   4. Agreed, checked on `camel-4.18.x`: `commit()` only calls `recordOffset`. 
Only `port/camel-4.22.x` is set, and the 4.22 upgrade guide has the entry under 
4.22.2 to 4.22.3.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to