gnodet-bot commented on code in PR #30124:
URL: https://github.com/apache/camel/pull/30124#discussion_r4580177720


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/ExampleHelper.java:
##########
@@ -566,6 +583,30 @@ public static Path downloadGithubExample(JsonObject entry, 
boolean deleteOnExit)
         return tempDir;
     }
 
+    private static String downloadFile(HttpClient hc, String url, Duration 
timeout) throws Exception {

Review Comment:
   💡 **Nit**: `throws Exception` is broader than necessary for this private 
method. `future.get()` can throw `InterruptedException` (not caught here) and 
the other paths throw `IOException`. `QuarkusHelper.get()` uses the narrower 
signature — this should match.
   
   ```suggestion
       private static String downloadFile(HttpClient hc, String url, Duration 
timeout) throws IOException, InterruptedException {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to