davsclaus commented on code in PR #30124:
URL: https://github.com/apache/camel/pull/30124#discussion_r4582661599


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/ExampleHelper.java:
##########
@@ -566,6 +583,30 @@ public static Path downloadGithubExample(JsonObject entry, 
boolean deleteOnExit)
         return tempDir;
     }
 
+    private static String downloadFile(HttpClient hc, String url, Duration 
timeout) throws Exception {

Review Comment:
   Done in 8723ee1d1a16: `downloadFile` now declares `throws IOException, 
InterruptedException`, like `QuarkusHelper.get()`. `new URI(url)` became 
`URI.create(url)` so the checked `URISyntaxException` goes away too.
   
   _Claude Code on behalf of davsclaus_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to