gnodet-bot commented on code in PR #30248:
URL: https://github.com/apache/camel/pull/30248#discussion_r4593747870


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -8557,6 +8557,15 @@ message expiry interval, content type, response topic, 
correlation data and user
 a publish no longer modifies. A topic alias or subscription identifiers set in 
the header object are not sent: the
 client assigns topic aliases for its connection, and subscription identifiers 
are sent by the server only.
 
+=== camel-paho-mqtt5 - a subscription the broker refuses fails the consumer
+
+The consumer now checks the reason code of the SUBACK. When the broker refuses 
the subscription (a reason code of 0x80
+or higher, such as 0x87 Not authorized), the subscribe fails with an 
`MqttException` that has that reason code, and
+the route does not start. When the subscription is refused after a reconnect 
(an automatic reconnect of the client, or
+the reconnect after a failed message with manualAcksEnabled), the route is 
restarted, and its start fails while the
+broker refuses the subscription; with a client given in the `client` option, 
an error is logged. Before, Paho returned

Review Comment:
   💡 **Style:** `manualAcksEnabled` should be wrapped in backticks for 
consistency with other option names in this paragraph (e.g. `` `client` `` on 
the next line).
   
   ```suggestion
   the reconnect after a failed message with `manualAcksEnabled`), the route is 
restarted, and its start fails while the
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to