allthingssecurity commented on PR #30248: URL: https://github.com/apache/camel/pull/30248#issuecomment-6943183368
@davsclaus thanks, you are right: the two corrections were in my local follow-up and never reached the branch. They are in faf5b55f8391 (on top of your rebase): - A forced disconnect during an automatic reconnect now fails that attempt with a lost connection, so the cycle is rescheduled as `MqttReconnectActionListener.onFailure` does, instead of ending. - `connecting = false` in the `finally` of the connect and of the reconnect is guarded with `forced == forcedDisconnects`, so an older connect cannot clear the flag of a newer one. - The class Javadoc says that a SUBACK that refuses a subscription is not modelled. - `PahoMqtt5SubscribeRefusedTest` waits with Awaitility `atMost` instead of Mockito `timeout()`. - `manualAcksEnabled` is in backticks in the upgrade guide (the bot's point). camel-paho-mqtt5 unit tests including the world's 1000 seeds: 1079 run, 0 failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
