Croway opened a new pull request, #30280:
URL: https://github.com/apache/camel/pull/30280

   JIRA: [CAMEL-27110](https://issues.apache.org/jira/browse/CAMEL-27110)
   
   - `camel bind` reads each Kamelet from the main branch of camel-kamelets 
(`PipeProvider`), and fills a step's properties with the example of the 
Kamelet. apache/camel-kamelets#3145 gave `set-body-action` the example `"Order 
${header.orderId} received"`.
   - On camel-4.18.x the bind templates are filled with `replaceFirst`, which 
reads `${header.orderId}` as a regex group reference, so since today `camel 
bind ... --step set-body-action` fails with `named capturing group is missing 
trailing '}'`, and `BindTest.shouldBindWithSteps` / `shouldBindWithUriSteps` 
fail, so every PR on this branch whose build reaches camel-jbang-core fails 
(for example #30272).
   - `Bind`, `ObjectReferenceBindingProvider` and `UriBindingProvider` now fill 
the templates with `String.replace`. These hunks are the template part of 
53b399d885e9, which is on camel-4.22.x and main since July; the other changes 
of that commit (`--property` arity, the kind regex, the query parameter merge) 
are left out.
   - The two tests now expect the example of the Kamelet, as on camel-4.22.x.
   
   Tests: all bind tests of camel-jbang-core on camel-4.18.x, 55/55 (`BindTest` 
failed 2 before, as on CI).
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to