JiriOndrusek commented on a change in pull request #1258:
URL: https://github.com/apache/camel-quarkus/pull/1258#discussion_r429999859
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
@oscerd I'm not still 100% sure about the licensing. But I've removed
mysql-connector. It seems that it is transitively add also by quarkus-jdbc-mysql
> [INFO] | \- io.quarkus:quarkus-jdbc-mysql:jar:1.5.0.CR1:compile
> [INFO] | \- mysql:mysql-connector-java:jar:8.0.20:compile
So I can run mysql container without need of license (eula), but I can not
use driver, right?
Does it mean, that it shouldn't be transitive in quarkus-jdbc-mysql, or is
this eula linked only to mysql-connector-java? (wich doesn't seem to be
correct, because I'm still using it)
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
@oscerd I'm not still 100% sure about the licensing. But I've removed
mysql-connector. It seems that it is transitively added also by
quarkus-jdbc-mysql
> [INFO] | \- io.quarkus:quarkus-jdbc-mysql:jar:1.5.0.CR1:compile
> [INFO] | \- mysql:mysql-connector-java:jar:8.0.20:compile
So I can run mysql container without need of license (eula), but I can not
use driver, right?
Does it mean, that it shouldn't be transitive in quarkus-jdbc-mysql, or is
this eula linked only to mysql-connector-java? (wich doesn't seem to be
correct, because I'm still using it)
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
@oscerd I'm not still 100% sure about the licensing. But I've removed
mysql-connector. It seems that it is transitively added also by
quarkus-jdbc-mysql
> [INFO] | \- io.quarkus:quarkus-jdbc-mysql:jar:1.5.0.CR1:compile
> [INFO] | \- mysql:mysql-connector-java:jar:8.0.20:compile
So I can run mysql container without need of license (eula), but I can not
use driver, right?
Does it mean, that it shouldn't be transitive in quarkus-jdbc-mysql, or is
this eula linked only to mysql-connector-java? (wich doesn't seem to be
correct, because I'm still using it)
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
@oscerd I'm not still 100% sure about the licensing. But I've removed
mysql-connector. It seems that it is transitively added also by
quarkus-jdbc-mysql
> [INFO] | \- io.quarkus:quarkus-jdbc-mysql:jar:1.5.0.CR1:compile
> [INFO] | (tab) \- mysql:mysql-connector-java:jar:8.0.20:compile
So I can run mysql container without need of license (eula), but I can not
use driver, right?
Does it mean, that it shouldn't be transitive in quarkus-jdbc-mysql, or is
this eula linked only to mysql-connector-java? (wich doesn't seem to be
correct, because I'm still using it)
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
@oscerd I'm not still 100% sure about the licensing. But I've removed
mysql-connector. It seems that it is transitively added also by
quarkus-jdbc-mysql
> [INFO] | \- io.quarkus:quarkus-jdbc-mysql:jar:1.5.0.CR1:compile
> [INFO] (tab) | \- mysql:mysql-connector-java:jar:8.0.20:compile
So I can run mysql container without need of license (eula), but I can not
use driver, right?
Does it mean, that it shouldn't be transitive in quarkus-jdbc-mysql, or is
this eula linked only to mysql-connector-java? (wich doesn't seem to be
correct, because I'm still using driver)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
