oscerd commented on a change in pull request #1258:
URL: https://github.com/apache/camel-quarkus/pull/1258#discussion_r429985073
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
This must be with scope provided, it's not compliant with the ASF
license.
##########
File path: integration-tests/debezium-common/pom.xml
##########
@@ -58,32 +74,36 @@
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
-
- <!-- test dependencies - camel-quarkus -->
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-testcontainers-support</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
Review comment:
mysql container doesn't require EULA, mssql server does. Quarkus doesn't
apply the ASF license policy or at least it's not subject to the ASF rules,
they only use the license. They shouldn't doing it, because
mysql-connector-java is not compliant with ASF license, but it's up to them.
In camel-quarkus we should exclude the mysql-connector-java from the
quarkus-jdbc-driver and redeclare it as provided. You're mixing mysql and
mssql: EULA is related only to the mssql testcontainer container.
Mysql-connector-java has a licensing problem related to ASF license compliancy:
we cannot use it explicitly in our projects, we need to make users providing
it, that's why it should be provided as scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
