djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635410111


   - I think for files that are not summary files, your code reads the file 
twice, first to determine it's not a summary page, and second to determine if 
it is in a group.  You could read the file once and apply both regex to 
determine both properties.
   
   - There needs to be a blank line after the header attributes before any 
content.  I think you removed this in some of the group files.
   
   - I think the changes to the group files are going to be overwritten when a 
java build is done.  We probably have to find a way to generate the group 
attribute from somewhere earlier.  I'll think about this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to