djencks commented on pull request #3860: URL: https://github.com/apache/camel/pull/3860#issuecomment-635522339
- You are still reading the file twice sometimes. I was thinking of replacing ``` if (summaryGroup != null || group != null) return true; return false; ``` with ``` return {summaryGroup, group} ``` Then you can test `groupInfo.summaryGroup` and `groupInfo.group`. - Modifying the files in components/../src is better than in docs/components/... but those files are partly generated as well, and I think the header attributes are currently entirely generated, so your changes may get overwritten. I think we can tweak the attribute generation to preserve specific attributes, including "group". Otherwise we can find a way to generate this attribute as well. The code is in tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java in the updateHeader method. I think I see how to do this, so unless you are eager to work on this code I'll fix it in a separate PR. Let me know. - I think having the summary pages you mention will be a good idea, but there should probably be some description of the group, which I'm not qualified to write. Let's add them and ask for someone to add some descriptive text. However, I think it would be better to add them in the PR for generating the index list on these pages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org