[ 
https://issues.apache.org/jira/browse/CASSANDRA-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849903#action_12849903
 ] 

Johan Oskarsson commented on CASSANDRA-850:
-------------------------------------------

+1, looks good to me. 

Couple of thoughts:
* Is there a reason to keep the junit 3.8.1 jar in lib and also use ivy to 
fetch junit 4.6?
* Due to my lack of legal expertise I will assume the bits in the notice file 
are sufficient.
* I remember someone voiced the opinion earlier that licenses should be pulled 
into a single file in the root, can't remember which of license/notice it was. 
Personally I think that this approach with one license file per jar approach is 
much more user friendly and surely it must be as valid from a legal standpoint?

> Ant release target doesn't include all jars in binary tarball
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-850
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>             Fix For: 0.6
>
>         Attachments: CASSANDRA-850.patch, 
> v2-0001-CASSANDRA-850-runtime-dependencies-formerly-handled-by.txt, 
> v2-0002-licensing-and-attribution-for-newly-added-jars.txt, 
> v2-0003-remove-default-runtime-ivy-config.txt, 
> v2-0004-remove-build-lib-jars-from-runtime-search-paths.txt, 
> v2-0005-do-not-ship-build.xml-and-ivy.xml-in-binary-dist.txt, 
> v2-0006-update-release-notes-and-readme-for-ivy-rollback.txt
>
>
> The ant release target doesn't create a complete tarball, the jars in 
> build/lib/jars are not included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to