[ https://issues.apache.org/jira/browse/CASSANDRA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854891#action_12854891 ]
Todd Blose edited comment on CASSANDRA-714 at 4/8/10 9:04 PM: -------------------------------------------------------------- Initial patch was done incorrectly. was (Author: todd): Here is an initial patch (there are obviously changes elsewhere, so I want to get some initial feedback first). There's a new thread local variable in Cassandra called keyspace. This is a string that is set after a successful login; otherwise, it defaults to null. rpc calls without a successful login will result in an undefined keyspace and a TException being thrown. I've also updated CassandraServer to use similar logic (I haven't updated checkLoginDone as to keep CASSANDRA-718 separate). If these changes sound good, I'll update the remaining areas of the code (CliClient and the python test script) and upload a final patch. It'll make sense to proceed with CASSANDRA-718 and CASSANDRA-859 after this. > remove keyspace argument from thrift methods > -------------------------------------------- > > Key: CASSANDRA-714 > URL: https://issues.apache.org/jira/browse/CASSANDRA-714 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 0.6 > Reporter: Eric Evans > Fix For: 0.7 > > > With the completion of CASSANDRA-547, the keyspace can be specified as part > of the login and stored in a thread-local. This will allow us to remove the > wasteful and redundant mandatory keyspace argument on all of the other rpc > methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.